Updated types; #19

2025-10-10T16:30:17Z

FrauJulian commented

2025-10-10 16:30:17 +00:00

(Migrated from github.com)

No description provided.

copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed

2025-10-10 16:31:00 +00:00

copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull Request Overview

This PR updates the TypeScript type exports by reorganizing type definitions and improving the build process. The changes ensure better type distribution and add TypeScript compilation checks to the pre-commit hook.

Moved type imports from ./index.d to ./types and exported types from the main index file
Updated package.json to point type definitions to the new types.d.ts file structure
Added TypeScript compilation check to the pre-commit hook for better code quality

Reviewed Changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated 3 comments.

File	Description
src/index.ts	Added type exports for VoiceAudioDataModel and VoiceConnectionDataModel
src/audio-manager.ts	Updated import path for types from `./index.d` to `./types`
package.json	Updated type definition paths to point to `types.d.ts` and bumped version
.husky/pre-commit	Added TypeScript compilation check to pre-commit hook

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

## Pull Request Overview This PR updates the TypeScript type exports by reorganizing type definitions and improving the build process. The changes ensure better type distribution and add TypeScript compilation checks to the pre-commit hook. - Moved type imports from `./index.d` to `./types` and exported types from the main index file - Updated package.json to point type definitions to the new `types.d.ts` file structure - Added TypeScript compilation check to the pre-commit hook for better code quality ### Reviewed Changes Copilot reviewed 4 out of 8 changed files in this pull request and generated 3 comments. | File | Description | | ---- | ----------- | | src/index.ts | Added type exports for VoiceAudioDataModel and VoiceConnectionDataModel | | src/audio-manager.ts | Updated import path for types from `./index.d` to `./types` | | package.json | Updated type definition paths to point to `types.d.ts` and bumped version | | .husky/pre-commit | Added TypeScript compilation check to pre-commit hook | <details> <summary>Files not reviewed (1)</summary> * **pnpm-lock.yaml**: Language not supported </details> --- <sub>**Tip:** Customize your code reviews with copilot-instructions.md. <a href="/FrauJulian/Discord-Audio-Stream/new/master/.github?filename=copilot-instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Create the file</a> or <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">learn how to get started</a>.</sub>

package.json

						
				@@ -21,3 +20,4 @@

				  "types": "./dist/types.d.ts",

				  "files": [

				    "dist"

				  ],

copilot-pull-request-reviewer[bot] (Migrated from github.com) commented

2025-10-10 16:31:00 +00:00

The package.json now references ./dist/types.d.ts for type definitions, but the main export in src/index.ts only exports types, not the actual implementation. This could break consumers who expect the main entry point to include both runtime code and types. Consider ensuring that ./dist/index.d.ts contains the complete type definitions including re-exported types from ./types.

The package.json now references `./dist/types.d.ts` for type definitions, but the main export in src/index.ts only exports types, not the actual implementation. This could break consumers who expect the main entry point to include both runtime code and types. Consider ensuring that `./dist/index.d.ts` contains the complete type definitions including re-exported types from `./types`.

copilot-pull-request-reviewer[bot] (Migrated from github.com) commented

2025-10-10 16:31:00 +00:00

The package.json now references ./dist/types.d.ts for type definitions, but the main export in src/index.ts only exports types, not the actual implementation. This could break consumers who expect the main entry point to include both runtime code and types. Consider ensuring that ./dist/index.d.ts contains the complete type definitions including re-exported types from ./types.

The package.json now references `./dist/types.d.ts` for type definitions, but the main export in src/index.ts only exports types, not the actual implementation. This could break consumers who expect the main entry point to include both runtime code and types. Consider ensuring that `./dist/index.d.ts` contains the complete type definitions including re-exported types from `./types`.

copilot-pull-request-reviewer[bot] (Migrated from github.com) commented

2025-10-10 16:31:00 +00:00

The package.json now references ./dist/types.d.ts for type definitions, but the main export in src/index.ts only exports types, not the actual implementation. This could break consumers who expect the main entry point to include both runtime code and types. Consider ensuring that ./dist/index.d.ts contains the complete type definitions including re-exported types from ./types.

  "types": "./dist/index.d.ts",

The package.json now references `./dist/types.d.ts` for type definitions, but the main export in src/index.ts only exports types, not the actual implementation. This could break consumers who expect the main entry point to include both runtime code and types. Consider ensuring that `./dist/index.d.ts` contains the complete type definitions including re-exported types from `./types`. ```suggestion "types": "./dist/index.d.ts", ```

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fraujulian/Discord-Audio-Stream#19