fraujulian/Discord-Audio-Stream
1
0
Fork 0
Code Issues Pull Requests 5 Actions Projects Releases 7 Wiki Activity

๐Ÿ› [BUG]: Reject non-finite volume percentages #69

New Issue
Closed
opened 2026-06-22 09:43:38 +00:00 by FrauJulian ยท 0 comments
FrauJulian commented 2026-06-22 09:43:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Description

AudioManager#setVolume() rejects values below 0 and above 100, but non-finite numbers such as NaN, Infinity, and -Infinity can pass the current range check. That can forward invalid volume values to resource.volume.setVolume().

Affected code: src/audio-manager.ts in setVolume().

Acceptance Criteria

  • setVolume() rejects NaN, Infinity, and -Infinity with AudioManagerConfigError.
  • Existing valid boundary values still work: 0 and 100.
  • Add a focused Jest regression test for non-finite volume values.
### Description `AudioManager#setVolume()` rejects values below `0` and above `100`, but non-finite numbers such as `NaN`, `Infinity`, and `-Infinity` can pass the current range check. That can forward invalid volume values to `resource.volume.setVolume()`. Affected code: `src/audio-manager.ts` in `setVolume()`. ### Acceptance Criteria - `setVolume()` rejects `NaN`, `Infinity`, and `-Infinity` with `AudioManagerConfigError`. - Existing valid boundary values still work: `0` and `100`. - Add a focused Jest regression test for non-finite volume values.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone v1.1
Projects
Clear projects
No projects
Assignees
Clear assignees
fraujulian (Julian Lechner)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fraujulian/Discord-Audio-Stream#69