From 2646bfaa8bfec438ed7e222c5332cdfe67bbb13f Mon Sep 17 00:00:00 2001 From: Julian Lechner Date: Thu, 24 Sep 2026 19:12:16 +0200 Subject: [PATCH] docs(skill): clarify WPF review triggers --- shared/skills/reviews/wpf-review/SKILL.md | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/shared/skills/reviews/wpf-review/SKILL.md b/shared/skills/reviews/wpf-review/SKILL.md index 3423004..c2712a2 100644 --- a/shared/skills/reviews/wpf-review/SKILL.md +++ b/shared/skills/reviews/wpf-review/SKILL.md @@ -1,10 +1,19 @@ --- name: wpf-review -description: Review WPF changes for correctness and maintainability. +description: Use when reviewing WPF, XAML, or MVVM desktop changes, including bindings, commands, resources, accessibility, lifecycle, and UI-thread behavior. --- # WPF Review -Inspect the changed WPF views, bindings, resources, commands, and lifecycle behavior. +Use when reviewing WPF, XAML, or MVVM desktop changes. -Return concrete findings and relevant verification. Keep detailed WPF standards for future customization. +## Review + +- Trace `DataContext`, binding paths, update modes, validation, and `INotifyPropertyChanged` behavior. Check collection updates and selection state. +- Review commands for enablement, asynchronous execution, cancellation, exception handling, and UI-thread affinity. +- Check resource dictionaries, styles, templates, theme behavior, and resource lookup scope. +- Inspect control names, focus and keyboard behavior, automation properties, and error feedback for accessibility. +- Check view and window lifetime, event subscriptions, disposal, timers, and owned resources for leaks or stale references. +- Review XAML parsing, converters, dependency properties, and virtualization for correctness and practical performance. + +Report concrete findings with the view, binding, or lifecycle path and user-visible impact. Recommend focused WPF verification; avoid framework-wide advice unrelated to the diff.