From 2ded5617af58be6e7c8a1e96d6863acdcb2f8a7d Mon Sep 17 00:00:00 2001 From: Julian Lechner Date: Thu, 24 Sep 2026 19:11:52 +0200 Subject: [PATCH] docs(skill): clarify code review triggers --- shared/skills/reviews/code-review/SKILL.md | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/shared/skills/reviews/code-review/SKILL.md b/shared/skills/reviews/code-review/SKILL.md index 01e5250..94333d0 100644 --- a/shared/skills/reviews/code-review/SKILL.md +++ b/shared/skills/reviews/code-review/SKILL.md @@ -1,12 +1,20 @@ --- name: code-review -description: Review code for correctness, maintainability, and regressions. +description: Use for a general review of a code diff when looking for concrete defects, regressions, compatibility issues, and maintainability risks. For focused API, security, performance, UI, WPF, or EF Core reviews, use the matching review skill. --- # Code Review -Inspect the change independently and report concrete findings with severity and evidence. +Review the requested diff independently for defects and material regression risk. -Check behavior, regressions, maintainability, unnecessary complexity, and verification. +## Workflow -Do not modify code unless explicitly asked. +1. Read the diff and the surrounding code, then identify the behavior and contracts the change intends to affect. +2. Trace callers and data flow through relevant shared helpers. Check normal, boundary, and failure paths rather than reviewing changed lines in isolation. +3. Look for incorrect behavior, compatibility breaks, unsafe input or data handling, resource leaks, concurrency problems, and avoidable complexity where relevant. +4. Check whether the change has focused verification and whether stated results match the evidence. Do not run broad checks by default. +5. Ignore style preferences unless they make the code error-prone or conflict with a repository rule. + +## Findings + +List only actionable issues, ordered by severity. Include file and line, condition, concrete impact, and the smallest practical fix. Do not modify code unless explicitly asked. If no defect is found, say so and note important unverified risks.