docs(skill): clarify pull request review triggers
This commit is contained in:
1 parent
e8fea95774
commit
afb9ea6521
1 file changed
+15
-3
@@ -1,10 +1,22 @@
|
|||||||
---
|
---
|
||||||
name: review-pull-request
|
name: review-pull-request
|
||||||
description: Review a pull request for correctness, risk, and readiness.
|
description: Use when reviewing a pull request or proposed diff for actionable defects, compatibility problems, security risks, and merge readiness. Do not implement review feedback.
|
||||||
---
|
---
|
||||||
|
|
||||||
# Review Pull Request
|
# Review Pull Request
|
||||||
|
|
||||||
Inspect the change and its context independently.
|
Review requested pull requests or proposed diffs for correctness, compatibility, and merge risk.
|
||||||
|
|
||||||
Report actionable findings first, followed by verification status and open risks.
|
## Workflow
|
||||||
|
|
||||||
|
1. Identify the target branch and exact diff. Read the relevant surrounding code, callers, tests, and configuration before judging a change.
|
||||||
|
2. Trace changed behavior through its entry points and consumers. Check error paths, boundary conditions, data handling, and security-sensitive flows when affected.
|
||||||
|
3. Compare the implementation with the stated requirement and established repository patterns. Distinguish a concrete defect from a preference or speculative concern.
|
||||||
|
4. Check compatibility of public APIs, file formats, migrations, configuration, and generated output where relevant.
|
||||||
|
5. Inspect available verification evidence. Run checks only when the review request and environment call for them; report unrun checks accurately.
|
||||||
|
|
||||||
|
## Findings
|
||||||
|
|
||||||
|
List actionable findings first, ordered by severity. For each, give the location, the triggering condition, the user or system impact, and a practical correction. Do not report issues already fixed in the diff. If no concrete finding remains, say so and note meaningful verification gaps.
|
||||||
|
|
||||||
|
Do not modify the reviewed change unless asked to implement the feedback.
|
||||||
Reference in new issue
Block a user