fraujulian/Personal-Portfolio-Website
1
0
Fork 0
Code Issues Pull Requests 7 Actions Projects Releases 2 Wiki Activity

Summarized current issues #9

Merged
FrauJulian merged 5 commits from summarized_current_issues into master 2025-07-25 12:44:10 +00:00
Conversation 1 Commits 5 Files Changed 6
+14 -13
FrauJulian commented 2025-07-25 12:38:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-07-25 12:38:47 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Pull Request Overview

This PR updates contact information and makes minor improvements to the application configuration and UI components. The changes primarily involve updating email addresses from the old domain to a new business domain.

  • Updated email addresses from fraujulian.xyz to lechner-systems.at domain
  • Fixed phone number format in global fields for proper tel: link functionality
  • Added scroll behavior configuration to the router and simplified HTML structure

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/global.fields.ts Updated contact email and fixed phone number format for href usage
src/app/imprint/imprint.component.ts Updated abuse email to new domain
src/app/home/home.component.html Simplified HTML structure by removing unnecessary span wrapper
src/app/app.config.ts Added scroll behavior configuration to router
## Pull Request Overview This PR updates contact information and makes minor improvements to the application configuration and UI components. The changes primarily involve updating email addresses from the old domain to a new business domain. - Updated email addresses from `fraujulian.xyz` to `lechner-systems.at` domain - Fixed phone number format in global fields for proper tel: link functionality - Added scroll behavior configuration to the router and simplified HTML structure ### Reviewed Changes Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment. | File | Description | | ---- | ----------- | | src/global.fields.ts | Updated contact email and fixed phone number format for href usage | | src/app/imprint/imprint.component.ts | Updated abuse email to new domain | | src/app/home/home.component.html | Simplified HTML structure by removing unnecessary span wrapper | | src/app/app.config.ts | Added scroll behavior configuration to router |
src/global.fields.ts
@@ -1,9 +1,9 @@
export class globalFields {
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-07-25 12:38:47 +00:00
Copy Link
Copy Source

The hrefContactPhone field contains a phone number but the original code had an email address. This suggests the original code was incorrect, but the variable name is misleading - it should be renamed to reflect that it contains a phone number, or the logic using this field should be verified.

  public static readonly hrefContactTel: string = '+436609254001';
The hrefContactPhone field contains a phone number but the original code had an email address. This suggests the original code was incorrect, but the variable name is misleading - it should be renamed to reflect that it contains a phone number, or the logic using this field should be verified. ```suggestion public static readonly hrefContactTel: string = '+436609254001'; ```
Sign in to join this conversation.
Reviewers
No Reviewers
copilot-pull-request-reviewer[bot]
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
fraujulian (Julian Lechner)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fraujulian/Personal-Portfolio-Website#9