fraujulian/Personal-Portfolio-Website
1
0
Fork 0
Code Issues Pull Requests 7 Actions Projects Releases 2 Wiki Activity

Summarized current issues #9

Merged
FrauJulian merged 5 commits from summarized_current_issues into master 2025-07-25 12:44:10 +00:00
Conversation 1 Commits 5 Files Changed 6
+8 -12
5 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 31c02fcc65 - Show all commits
angular.json
+1 -3
View File
@@ -37,9 +37,7 @@
], ],
"scripts": [], "scripts": [],
"server": "src/main.server.ts", "server": "src/main.server.ts",
"prerender": { "prerender": true,
"routes": ["/", "/imprint"]
},
"ssr": { "ssr": {
"entry": "src/server.ts" "entry": "src/server.ts"
} }
package-lock.json
Generated
+2 -2
View File
@@ -1,12 +1,12 @@
{ {
"name": "angular-portfolio-seite", "name": "angular-portfolio-seite",
"version": "3.0.10", "version": "3.1.11",
"lockfileVersion": 3, "lockfileVersion": 3,
"requires": true, "requires": true,
"packages": { "packages": {
"": { "": {
"name": "angular-portfolio-seite", "name": "angular-portfolio-seite",
"version": "3.0.10", "version": "3.1.11",
"dependencies": { "dependencies": {
"@angular/animations": "^19.2.14", "@angular/animations": "^19.2.14",
"@angular/cdk": "^19.2.19", "@angular/cdk": "^19.2.19",
src/app/home/home.component.html
-2
View File
@@ -70,9 +70,7 @@
<div class="contact-area"> <div class="contact-area">
<a [href]="contactSafeMail"> <a [href]="contactSafeMail">
<span>
<fa-icon [icon]="faEnvelope" size="3x"></fa-icon> <fa-icon [icon]="faEnvelope" size="3x"></fa-icon>
</span>
</a> </a>
<a href="tel:{{globalFields.hrefContactPhone}}"> <a href="tel:{{globalFields.hrefContactPhone}}">
src/app/imprint/imprint.component.ts
+1 -1
View File
@@ -23,7 +23,7 @@ export class ImprintComponent implements OnInit {
protected readonly zip: number = 3380; protected readonly zip: number = 3380;
protected readonly city: string = 'Pöchlarn'; protected readonly city: string = 'Pöchlarn';
protected readonly country: string = 'Austria'; protected readonly country: string = 'Austria';
protected readonly abuseMail: string = 'abuse@fraujulian.xyz'; protected readonly abuseMail: string = 'abuse@lechner-systems.at';
protected contactSafeMail!: SafeUrl; protected contactSafeMail!: SafeUrl;
protected abuseSafeMail!: SafeUrl; protected abuseSafeMail!: SafeUrl;
src/global.fields.ts
+2 -2
View File
@@ -1,9 +1,9 @@
export class globalFields { export class globalFields {
copilot-pull-request-reviewer[bot] commented 2025-07-25 12:38:47 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

The hrefContactPhone field contains a phone number but the original code had an email address. This suggests the original code was incorrect, but the variable name is misleading - it should be renamed to reflect that it contains a phone number, or the logic using this field should be verified.

  public static readonly hrefContactTel: string = '+436609254001';
The hrefContactPhone field contains a phone number but the original code had an email address. This suggests the original code was incorrect, but the variable name is misleading - it should be renamed to reflect that it contains a phone number, or the logic using this field should be verified. ```suggestion public static readonly hrefContactTel: string = '+436609254001'; ```
public static readonly firstname: string = 'Julian'; public static readonly firstname: string = 'Julian';
public static readonly lastname: string = 'Lechner'; public static readonly lastname: string = 'Lechner';
public static readonly contactMail: string = 'contact@fraujulian.xyz'; public static readonly contactMail: string = 'office@lechner-systems.at';
public static readonly contactPhone: string = '+43 (0) 660 9254001'; public static readonly contactPhone: string = '+43 (0) 660 9254001';
public static readonly hrefContactPhone: string = 'contact@fraujulian.xyz'; public static readonly hrefContactPhone: string = '+436609254001';
public static readonly githubUsername: string = 'FrauJulian'; public static readonly githubUsername: string = 'FrauJulian';
public static readonly numberOfLoadedRepositories: number = 999; public static readonly numberOfLoadedRepositories: number = 999;
} }