docs(skill): clarify WPF review triggers

This commit is contained in:
fraujulian committed 2026-09-24 19:12:16 +02:00
1 parent bc0fd83e14
commit 2646bfaa8b
1 file changed
+12 -3
+12 -3
View File
@@ -1,10 +1,19 @@
---
name: wpf-review
description: Review WPF changes for correctness and maintainability.
description: Use when reviewing WPF, XAML, or MVVM desktop changes, including bindings, commands, resources, accessibility, lifecycle, and UI-thread behavior.
---
# WPF Review
Inspect the changed WPF views, bindings, resources, commands, and lifecycle behavior.
Use when reviewing WPF, XAML, or MVVM desktop changes.
Return concrete findings and relevant verification. Keep detailed WPF standards for future customization.
## Review
- Trace `DataContext`, binding paths, update modes, validation, and `INotifyPropertyChanged` behavior. Check collection updates and selection state.
- Review commands for enablement, asynchronous execution, cancellation, exception handling, and UI-thread affinity.
- Check resource dictionaries, styles, templates, theme behavior, and resource lookup scope.
- Inspect control names, focus and keyboard behavior, automation properties, and error feedback for accessibility.
- Check view and window lifetime, event subscriptions, disposal, timers, and owned resources for leaks or stale references.
- Review XAML parsing, converters, dependency properties, and virtualization for correctness and practical performance.
Report concrete findings with the view, binding, or lifecycle path and user-visible impact. Recommend focused WPF verification; avoid framework-wide advice unrelated to the diff.